Skip to content

DSP_PRESENT flag is needed for Armv8m devices having DSP enabled #9404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2019
Merged

DSP_PRESENT flag is needed for Armv8m devices having DSP enabled #9404

merged 1 commit into from
Jan 23, 2019

Conversation

deepikabhavnani
Copy link

Description

DSP_PRESENT flag is needed for Armv8m devices having DSP enabled

Reference
http://www.keil.com/pack/doc/CMSIS/DSP/html/index.html

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@cmonr
Copy link
Contributor

cmonr commented Jan 17, 2019

Is this not also needed for Cortex-M4F targets?

@deepikabhavnani
Copy link
Author

M4 has optional FPU, but DSP is not optional, hence not needed

@deepikabhavnani
Copy link
Author

Set the flag to be explicitly as true (1)

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 21, 2019

@deepikabhavnani ready for CI?

@deepikabhavnani
Copy link
Author

Yes ready for CI

mmahadevan108
mmahadevan108 approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 22, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 22, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test

@deepikabhavnani
Copy link
Author

jenkins-ci/mbed-os-ci_dynamic-memory-usage

Not sure how to check this, no failing artifact for this

jenkins-ci/mbed-os-ci_greentea-test

No failing artifact

@cmonr
Copy link
Contributor

cmonr commented Jan 23, 2019

...huh. Looks like this was a legit CI issue.

Something related to docker. @ARMmbed/mbed-os-test-team has been ping'd.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 23, 2019

test restarted

@0xc0170 0xc0170 merged commit 129889b into ARMmbed:master Jan 23, 2019
@deepikabhavnani deepikabhavnani deleted the dsp_flag branch January 23, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@bridadan bridadan bridadan approved these changes

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

@theotherjimmy theotherjimmy Awaiting requested review from theotherjimmy

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deepikabhavnani @cmonr @0xc0170 @mbed-ci @bridadan @mmahadevan108